On Wed, 12 Mar 2008, Daniel Dickman wrote:

Applied - thanks (and your bind one too)

-d

On 16:13:10 Mar 14, Ermal Lu?i wrote:

It is not arguable at all.

I did my first implementation in kernel and the second in userland. I
agree the userland design is far more complex but that is the right way
to do things.

pf(4) has no business diddling with application level packets.

No problem. I did not mean that either.

Those were the first cut versions. My final patch has been substantially
reworked, the design completely changed and so on.

But you don't find that in the archives.

getcwd calls VOP_READDIR without first calling VOP_OPEN. The man page
isn't clear about whether or not directories need be opened or only
files, but the only other use of VOP_READDIR is in getdirentries(2),
which calls VOP_OPEN by virtue of working on a file descriptor.

d.

Index: vfs_getcwd.c
===================================================================
RCS file: /cvs/src/sys/kern/vfs_getcwd.c,v
retrieving revision 1.12
diff -u -r1.12 vfs_getcwd.c
--- vfs_getcwd.c 7 Aug 2007 07:41:59 -0000 1.12
+++ vfs_getcwd.c 15 Mar 2008 00:04:27 -0000
@@ -126,6 +126,8 @@
dirbuf = malloc(dirbuflen, M_TEMP, M_WAITOK);

off = 0;
+ if ((error = VOP_OPEN(uvp, FREAD, p->p_ucred, p)) != 0)
+ goto out;

On Fri, Mar 14, 2008 at 3:43 PM, Girish Venkatachalam
gmail.com> wrote:

On 14:56:31 Mar 14, Ermal Lu?i wrote:

packet:

Firstly PPTP should not be done in the kernel.

Secondly there is already an implementation under review.

Sean Kennedy wrote:

Dmitri Alenitchev wrote a few articles once upon a time, I keep them bookmarked.. not sure where he's at these days though. ;)

http://allroot.blogspot.com/2006/10/hacking-usb-device-drivers-part-1.html
http://allroot.blogspot.com/2006/10/hacking-usb-device-drivers-part-2.html

(Whoops, accidentally @misc'd it.)

On Fri, Mar 14, 2008 at 1:09 PM, Reyk Floeter openbsd.org> wrote:

Thanks, for the interest in this.

While i should be more careful when sending these mails.
For anybody willing to try this there is an error on rewriting back the packet:
the line
+ m_copyback(m, off + sizeof(*th) + sizeof(struct pptpMsgHead) +
+ sizeof(struct pptpCallIds), sizeof(nport), (caddr_t)&nport);

should read

+ m_copyback(m, off + sizeof(*th) + sizeof(struct pptpMsgHead),
+ sizeof(*cptr), (caddr_t)cptr);

On 2008/03/14 08:59, Sean Kennedy wrote:

First you need to check the device ID (usbdevs -v) and make sure
there's a relevant entry in sys/dev/usb/usbdevs. If necessary, add
one and run 'make'.

Then look at an existing driver that you think might be a reasonably
close match and see how USB_VENDOR_xx and USB_PRODUCT_xx are matched,
you can then try adding the device.

For what it's worth, I'm interested too in a tech@ tutorial on (How to add
Unknown, or Semi-Known USB) devices.

I have had success with adding commonly defined things (Keyboards Mice, and
the occasional USB wireless/wired Network adapter)

But for something that has little or no description, (and no blobs) and
FreeBSD or NetBSD support (L*nux documentation too, but avoiding GPL)
It would be nice to see if I could add in USB support.

There really is no RT*M reference I could find at the best of times, to direct
where to begin.

-sean

ok, we have some pf pptp implementations now to look at

On Fri, Mar 14, 2008 at 10:59:28AM +0100, Ermal Lu?i wrote: