Package: cdebconf-entropy
Version: 0.7
Severity: minor

The following dialog has been discussed before:
Key data has been created successfully

My personal main objection is that the message is rather meaningless and
confusing to users. The term "key data" is vague and has not previously
been introduced.

I would suggest to replace it with a different dialog (that is possibly
displayed at a later point in the code) that simply says:
The random key has been created successfully.

I also suggest changing:
Enter random characters or move mouse randomly
to:
Enter random characters or make random movements with your mouse

Also, the newt frontend (and presumably also the gtk one) have a "Continue"
button that is not accessible; at least in the newt frontend you cannot use
"tab" to activate it.

On Wednesday 30 April 2008, Frans Pop wrote:

Looks like the "Continue" button becomes active automatically after enough
entropy has been gathered (same dialog remains displayed, but its text
changes and the button becomes active).
Maybe it should just be hidden while entropy is still being gathered.

This could still be useful.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBIF7Khgm/Kwh6ICoQRAp9MAJ0Wg8+SSyjmQ+0GGiu6er+Oak/thQCfeP1j
hNnoihHllCvo3TyiK4dV0Lw=
=S3Dq
-----END PGP SIGNATURE-----

On Wednesday 30 April 2008, Frans Pop wrote:

Maybe even:
The encryption key for , has been created successfully.

That would match the intro text in the dialog to enter random characters.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBIF7Hlgm/Kwh6ICoQRApzOAKDZMo+kFBNr+Ku1WAM/VHlguK87MgCbBOTw
cwLpqdEC0LrdlaK2oGe7DRI=
=FA7q
-----END PGP SIGNATURE-----

On Wed, Apr 30, 2008 at 01:43:20AM +0200, Frans Pop wrote:

Agreed.

Agreed here too. I'll change the newt frontend to allow aborting.

Jérémy, does the gtk frontent already offer to abort or would it
also have to be adapted?

Max

On Wed, Apr 30, 2008 at 01:40:21AM +0200, Frans Pop wrote:

Good suggestion - thanks!

Saying that the encryption key has been created is a lot more
meaningful than talking about "key data".

(Talking about "Random key" here might be confusing, as we
already use the term in the "Key type" option with a different
meaning. Here we mean: "The persistent encryption key has been
created from a random source". For the key type, we mean "The
key is non-persistent and will be recreated from a random source
(and data will effectively destroyed) each time it is used.")

On Saturday 03 May 2008, Max Vozeler wrote:

IMO not needed. It would be good to post the patch to the BR first for
review though.

Note that Otavio has just started preparations for Beta2 and I think we
should delay this string change until just after that.

Same probably goes for the other changes in this BR.

On Sat, May 03, 2008 at 10:12:05PM +0200, Max Vozeler wrote:

Strange - we already do, but the cancel button is not shown.
We show it only if the frontend indicates that it can go back
(newt_can_go_back()).

I'm currently lost as to why the frontend would not have the
BACKUP capability. It does when I build cdebconf locally. Any
ideas? Else I will try to dig deeper..

Max

On Sun, May 04, 2008 at 03:19:19PM +0200, Max Vozeler wrote:

That was just missing a call to db_capb backup :-)

Fixed in SVN. The entropy dialog can now be cancelled.

Max

tags 478591 + patch
thanks

On Sat, May 03, 2008 at 10:45:22PM +0200, Frans Pop wrote:

Patch attached - Review is much appreciated :-)

Okay. Let's delay it.

Max

On Sunday 04 May 2008, Max Vozeler wrote:

Hmm. Should the string not also be changed in the templates and .c code of
cdebconf-entropy for all frontends?
String itself is fine by me.

Also, that does not cover the other suggestion I had for a string change. We
should probably do both at the same time.

! I also suggest changing:
! Enter random characters or move mouse randomly
! to:
! Enter random characters or make random movements with your mouse