Bug#445011: xfsprogs: fsck.xfs doesn't verify that the device exists
  Home FAQ Contact Sign in
linux.debian.bugs.dist only
 
Advanced search
POPULAR GROUPS

more...

linux.debian.bugs.dist Profile…
 Up
Bug#445011: xfsprogs: fsck.xfs doesn't verify that the device exists         


Author: Wayne Tucker
Date: Oct 2, 2007 11:30

Package: xfsprogs
Version: 2.8.11-1
Severity: normal
Tags: patch

fsck.xfs doesn't check to see if the device it is asked to check
exists. This can result in a system booting with an incomplete set of
filesystem mounts. The included patch works for me, although I only
have a limited number of systems on which to test it.

-- System Information:
Debian Release: 4.0
APT prefers stable
APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-4-xen-amd64
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Show full article (1.07Kb)
3 Comments
Bug#445011: xfsprogs: fsck.xfs doesn't verify that the device exists         


Author: Nathan Scott
Date: Oct 2, 2007 16:10

Hi Wayne,

On Tue, 2007-10-02 at 10:38 -0700, Wayne Tucker wrote:
>
>
> fsck.xfs doesn't check to see if the device it is asked to check
> exists. This can result in a system booting with an incomplete set of
> filesystem mounts. The included patch works for me, although I only
> have a limited number of systems on which to test it.

Hmm, OK - seems safe enough I guess. It'd be nice to understand
the root cause here a bit - is the problem that we dont attempt to
access /dev/foo at all, so udev doesn't see any requests for that
device and doesnt create the device node? Then later when we try
to mount, the mount userspace code gets ENODEV? If so, I wonder
why the mount doesn't populate the device nodes on its access?

Also, the NFS fsck program is also a shell script, I wonder if it
might suffer similar issues and need a similar patch? Possibly not
since theres no local device involved there.

I'll send the patch upstream and solicit their thoughts as well.

thanks.
Show full article (1.16Kb)
no comments
Bug#445011: xfsprogs: fsck.xfs doesn't verify that the device exists         


Author: Wayne Tucker
Date: Oct 2, 2007 17:50

Nathan Scott wrote:
> Hi Wayne,

Hello Nathan,
> On Tue, 2007-10-02 at 10:38 -0700, Wayne Tucker wrote:
>>
>> fsck.xfs doesn't check to see if the device it is asked to check
>> exists. This can result in a system booting with an incomplete set of
>> filesystem mounts. The included patch works for me, although I only
>> have a limited number of systems on which to test it.
>
> Hmm, OK - seems safe enough I guess. It'd be nice to understand
> the root cause here a bit - is the problem that we dont attempt to
> access /dev/foo at all, so udev doesn't see any requests for that
> device and doesnt create the device node? Then later when we try
> to mount, the mount userspace code gets ENODEV? If so, I wonder
> why the mount doesn't populate the device nodes on its access?

My knowledge of udev is pretty limited, so I'm not sure if that would
come into play at all.
Show full article (2.35Kb)
no comments
Bug#445011: xfsprogs: fsck.xfs doesn't verify that the device exists         


Author: Nathan Scott
Date: Oct 2, 2007 18:10

On Tue, 2007-10-02 at 17:23 -0700, Wayne Tucker wrote:
>
> In my case, the missing devices are being caused by intermittent
> XENBUS
> timeouts. The the VM boots but doesn't realize that /var/log isn't
> mounted. There's an underlying issue that needs to be resolved
> there,
> but the same problem could happen on normal machines in the event that
> a
> physical device is dead.
>

Fair enough. I'm sure the xfs maintainers will merge this (I've
sent them some mail), & I'll upload the fixed package once they do.

cheers.

--
Nathan

--
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
no comments