|
|
 Up |
|
  |
Author: Julian MehnleJulian Mehnle Date: Sep 20, 2007 22:00
Package: debarchiver
Version: 0.7.4
Followup-For: Bug #437508
debarchiver now _always_ warns in syslog:
| debarchiver: Warning: Loading config file / etc/debarchiver.conf:
| debarchiver: ^I
| debarchiver: ^I
even if there is no error condition!
I think you changed one log level too many from 4 to 3. And what's this
double "^I" log output?
-- System Information:
Debian Release: lenny/sid
APT prefers testing
APT policy: (600, 'testing'), (90, 'unstable')
Architecture: i386 (i586)
Kernel: Linux 2.6.21-2-486
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
|
| Show full article (1.16Kb) |
|
| | 12 Comments |
|
|
Author: Ola LundqvistOla Lundqvist Date: Sep 20, 2007 22:40
Package: debarchiver
Version: 0.7.4
Severity: normal
Hi
Thanks for the information. I'm creating a new bug for this now.
Please send me the output from
debarchiver --dl 5
and the /etc/debarchiver.conf file.
Best regards,
// Ola
On Thu, Sep 20, 2007 at 07:45:40PM +0000, Julian Mehnle wrote:> Package: debarchiver
> Version: 0.7.4
> Followup-For: Bug #437508
>
> debarchiver now _always_ warns in syslog:
>
> | debarchiver: Warning...
|
| Show full article (1.96Kb) |
|
| | no comments |
|
|
Author: Ola LundqvistOla Lundqvist Date: Sep 21, 2007 17:50
Hi Julian
I think you need to end the configuration file with
1;
Please try that and tell me if the warning disappear.
The ^I part is the error output from perl. It should contain the error
code and error string. I do not know why it is ^I in your case.
Best regards,
// Ola
On Fri, Sep 21, 2007 at 12:33:20PM +0000, Julian Mehnle wrote:
> Ola Lundqvist wrote:
>> Please send me the output from
>>
>> debarchiver --dl 5
>>
>> and the /etc/debarchiver.conf file.>
> See attachments.
> io:~> sudo -H -u bitshapers /usr/bin/debarchiver -so --scanall -i /proj/bitshapers/debarchive/incoming --dl 5
> Password:
> Warning: Loading config file / etc/debarchiver.conf:
>
>
> Debug: Change to...
|
| Show full article (6.72Kb) |
| no comments |
|
|
Author: Julian MehnleJulian Mehnle Date: Sep 22, 2007 03:40
Ola Lundqvist wrote:
> I think you need to end the configuration file with
>
> 1;
Why would that make a difference? The last statement is ...
$gpgkey = '74E1D63F';
which returns a true value. So this is equivalent to a trailing "1;".
> Please try that and tell me if the warning disappear.
As expected, it did not make the warning go away.
> The ^I part is the error output from perl. It should contain the error
> code and error string. I do not know why it is ^I in your case.
Odd.
So can you do something about debarchiver filling up my syslog despite
everything working fine?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
|
| Show full article (0.80Kb) |
| no comments |
|
|
Author: Ola LundqvistOla Lundqvist Date: Sep 23, 2007 00:30
Hi Julian
On Sat, Sep 22, 2007 at 01:27:11AM +0000, Julian Mehnle wrote:
> Ola Lundqvist wrote:
>> I think you need to end the configuration file with
>>
>> 1;
>
> Why would that make a difference? The last statement is ...
>
> $gpgkey = '74E1D63F';
>
> which returns a true value. So this is equivalent to a trailing "1;".
That is what I was unsure of. I did not have the time to check.
>> Please try that and tell me if the warning disappear.
>
> As expected, it did not make the warning go away.
Ok.
|
| Show full article (1.50Kb) |
| no comments |
|
|
Author: Ola LundqvistOla Lundqvist Date: Sep 23, 2007 11:40
tags 443405 + unreproducible help
thanks
Hi Julian
I have now tried to reproduce your problem, but failed.
The current code that cause the warning looks like this:
if (-e $etcconfigfile) {
my $t = do $etcconfigfile;
unless ($t) {
pdebug(3, "Loading config file $etcconfigfile:\n\t$!\n\t$@");
}
}
So I created the following test code:
my $t = do " test.conf";
unless ($t) {
print "Error\n$!\n$@\n";
}
And then copied your config file to test.conf.
I did not get any output.
|
| Show full article (2.15Kb) |
| no comments |
|
|
Author: Julian MehnleJulian Mehnle Date: Sep 23, 2007 14:00
# This is a sample configuration file.
#
# The configuration file consist of perl variables that can be set to
# different values. The suggested value in this sample configuration file
# is the default value set by debarchiver.
# $destdir = "/var/lib/debarchiver/dists";
# $inputdir = "/var/lib/debarchiver/incoming";
# $copycmd = "cp -af";
# $movecmd = "mv";
# $rmcmd = "rm -f";
# $vrfycmd = "dscverify";
# $cinstall = "installed";
# $distinputcriteria = "^linux.*\\.deb\$";
# Choose to enable or disable signature verification for packages uploaded
# into $inputdir (not %%distinputdirs).
# $verifysignatures = 0;
# Choose to enable or disable signature verification for packages uploaded
# into %%distinputdirs. This works indepentently from $verifysignatures.
# $verifysignaturesdistinput = 0;
|
| Show full article (5.08Kb) |
| no comments |
|
|
Author: Julian MehnleJulian Mehnle Date: Sep 23, 2007 17:20
Ola Lundqvist wrote:
> On Sun, Sep 23, 2007 at 11:49:36AM +0000, Julian Mehnle wrote:
>> So I think debarchiver should check $! and $@ rather than the result
>> of do() ("unless ($t)"), which really says nothing about whether the
>> file could be read and compiled successfully, UNLESS you require
>> every configuration file to end with a true-valued statement (which
>> the debarchiver man-page says nothing about). And I would not make
>> such a requirement. Checking $! and $@ should do just fine.
>
> The problem here is that $! $@ can contain quite different values, as
> you noticed... I do not know if perl actually requires the file to end
> with a true statement or not. Maybe it does. I have not checked the
> documentation for that.
`perldoc -f do` says:
| If "do" cannot read the file, it returns undef and sets $! to the error.
| If "do" can read the file but cannot compile it, it returns undef and
| sets an error message in $@. If the file is successfully compiled,
| "do" returns the value of the last expression evaluated.
Thus relying on $! and $@ is officially sanctioned.
|
| Show full article (1.42Kb) |
| no comments |
|
|
Author: Ola LundqvistOla Lundqvist Date: Sep 23, 2007 17:20
Hi again
Now I have checked the documentation and it says like this:
If do cannot read the file, it returns undef and sets $! to the error.
If do can read the file but cannot compile it, it returns undef and sets
an error message in $@ . If the file is successfully compiled, do returns
the value of the last expression evaluated.
>From this I can only determine that I have to document the return
value in the configuration file.
I checked the config file and it do not return anything. That will
also be corrected.
Thanks for your help.
Best regards,
// Ola
On Sun, Sep 23, 2007 at 11:49:36AM +0000, Julian Mehnle wrote:
> Ola Lundqvist wrote:
>> I have now tried to reproduce your problem, but failed.
>>
>> The current code that cause the warning looks like...
|
| Show full article (6.34Kb) |
| no comments |
|
|
|
|
|
|
|
|
|
|
