|
|
 Up |
|
|
  |
Author: Sergiu IvanovSergiu Ivanov
Date: Jul 23, 2008 02:00
Hello,
On Thu, Jul 17, 2008 at 3:33 PM, Sergiu Ivanov gmail.com>
wrote:
> On Wed, Jul 16, 2008 at 2:32 AM, gmx.net> wrote:
>>> On Tue, Jul 15, 2008 at 06:10:02PM +0300, Sergiu Ivanov wrote:
>>> I have written a libtrivfs-based translator (the source code...
|
| Show full article (2.57Kb) |
|
| |
no comments
|
|
|
Author: Barry deFreeseBarry deFreese
Date: Jul 22, 2008 21:58
How about this one?
Not too sure about the syntax of the changelog.
Thanks!
Barry deFreese
2008-07-23 Barry deFreese comcast.net>
* i386/i386/locore.h (copyinmsg, copyoutmsg):
Cast parameters as void* rather than vm_offset_t.
* i386/i386at/com.c (comportdeath): Cast port as ipc_port_t in
tty_portdeath call.
* i386/i386at/kd...
|
| Show full article (10.36Kb) |
|
| |
no comments
|
|
|
Author: Samuel ThibaultSamuel Thibault
Date: Jul 22, 2008 15:49
Barry deFreese, le Tue 22 Jul 2008 13:33:07 -0400, a écrit :
> I'm a little curious if using (void *)port cast is correct in the calls
> to tty_portdeath()?
Rather cast into the target type instaed, ipc_port_t.
> I also could use some guidance on these warnings (they all come from
> basically the same call):
>
> ../kern/startup.c:297: warning: passing argument 1 of 'kvtophys' makes
> integer from pointer without a cast
See inside the PMAP_ACTIVATE_USER macro.
> --- i386/i386at/kd.c 20 Jul 2008 17:05:38 -0000 1.5.2.15
> +++ i386/i386at/kd.c 22 Jul 2008 17:12:40 -0000
> @@ -590,7 +590,7 @@ kdportdeath(dev, port)
> dev_t dev;
> mach_port_t port;
> {
> - return (tty_portdeath(&kd_tty, port));
> + return (tty_portdeath(&kd_tty, (void *)port));
> }
|
| Show full article (2.74Kb) |
|
no comments
|
|
|
Author: Roland McGrathRoland McGrath
Date: Jul 22, 2008 13:21
> Shouldn't we nevertheless `vm_deallocate' the memory region?
Yes, thanks.
|
| |
|
no comments
|
|
|
Author: Barry deFreeseBarry deFreese
Date: Jul 22, 2008 10:33
Hi folks,
Here is another patch that cleans up the "makes foo from bar without a
cast" warnings.
I'm a little curious if using (void *)port cast is correct in the calls
to tty_portdeath()?
I also could use some guidance on these warnings (they all come from
basically the same call):
../kern/startup.c:297: warning: passing argument 1 of 'kvtophys' makes
integer from pointer without a cast
../i386/i386/pcb.c:236: warning: passing argument 1 of 'kvtophys' makes
integer from pointer without a cast
../i386/i386/pcb.c:311: warning: passing argument 1 of 'kvtophys' makes
integer from pointer without a cast
Also, I am still not "fixing" anything under linux/*
I haven't included a changelog yet since this will probably need
reviewed and/or fixed.
Thanks as always,
Barry
|
| Show full article (6.57Kb) |
|
no comments
|
|
|
Author: Thomas SchwingeThomas Schwinge
Date: Jul 22, 2008 07:54
Hello!
On Tue, Jul 22, 2008 at 02:33:34PM +0100, Samuel Thibault wrote:
> It looks like the hangs we're encountering on flubber/gnubber and which
> I'm having on the buildd are due to syslog() blocking somewhere.
Interesting...
While being at syslog, I can again point to this issue,
< http://lists.gnu.org/archive/html/bug-hurd/2007-02/msg00042.html>, which
is probably unrelated, but in case someone is going to have a look at the
syslog code/other involved code nevertheless...
Regards,
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
iD8DBQFIhfS3gfzh735dTTURAheXAKCGqalDnzRw58PCCavZfwgmPgYsXACguhP5
TyV4PHYTij8bUjG7PhZOD0Q=
=FNRO
-----END PGP SIGNATURE-----
|
| |
|
no comments
|
|
|
Author: Samuel ThibaultSamuel Thibault
Date: Jul 22, 2008 06:33
It looks like the hangs we're encountering on flubber/gnubber and which
I'm having on the buildd are due to syslog() blocking somewhere.
Samuel
|
| |
|
no comments
|
|
|
Author: Thomas SchwingeThomas Schwinge
Date: Jul 22, 2008 02:34
Hello!
On Mon, Jul 21, 2008 at 12:50:50PM -0700, Roland McGrath wrote:
> It's bogus, i.e. a violation of Hurd protocols, for an io server to send
> back more data than requested. But it's possible with a buggy or malicious
> server. So it is appropriate paranoia on the client side to check for this
> rather than turning it into a buffer overrun.
>
> If this occurs, it's a protocol violation and should not be papered over.
Correct. Also, because the internal state of the server (current reading
offset) anyway wouldn't be correct anymore.
> So rather than just ignore the extra data, I made it return EGRATUITOUS.
> (This error code means, "a Hurd server violated its protocol".)
Shouldn't we nevertheless `vm_deallocate' the memory region?
Regards,
Thomas
PS: What's the needed make invocation magic to have glibc recreate the
`hurd/RPC*.c' files? ``make hurd/subdir_lib'' doesn't work for me.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
|
| Show full article (1.12Kb) |
|
no comments
|
|
|
Author: Barry deFreeseBarry deFreese
Date: Jul 21, 2008 20:35
On Tue, 2008-07-22 at 03:37 +0100, Samuel Thibault wrote:
> Barry deFreese, le Mon 21 Jul 2008 22:15:17 -0400, a écrit :
>> (kdstop): Return 0 at end of function.
>
> Mmm, kdstop should probably just return void, like kdstart. You'll also
> need to fix the t_stop and t_start members of struct tty accordingly.
>
> Else, it looks fine.
>
> Samuel
OK, how about now?
Thanks Samuel!
Barry
2008-07-19 Barry deFreese comcast.net>
* chips/busses.h (struct bus_ctlr): *intr return void instead of int.
* i386/i386/ipl.h (ivect[]): return void instead of int.
* i386/i386at/pic_isa.h (ivect[]): Likewise.
* i386/i386at/kd_mouse.c...
|
| Show full article (13.70Kb) |
|
no comments
|
|
|
|
|
|
Author: Samuel ThibaultSamuel Thibault
Date: Jul 21, 2008 19:37
Barry deFreese, le Mon 21 Jul 2008 22:15:17 -0400, a écrit :
> (kdstop): Return 0 at end of function.
Mmm, kdstop should probably just return void, like kdstart. You'll also
need to fix the t_stop and t_start members of struct tty accordingly.
Else, it looks fine.
Samuel
|
| |
|
no comments
|
|
|
|
|
|
|
