I have a small Perl application that searches through a series of
directories chosen by the user for files containing a pattern or group
of patterns. The file names and matching patterns are returned to the
user sorted by the file's modification time.The user also has the
choice of how far back in time to search and how many lines of output
he wants to see for each file.

With an expected and current increase of files and file sizes, the
application is bogging down a bit. I didn't design it with performance
in mind and I will be reviewing what I've done, but are there general
rules or specific suggestions you could offer to enhance performance?

Basically: the script uses perl's system command to run a long winded
"find" command which is piped to sed to correct patterns that match
HTML markers. The matching lines are then shoved into an array. The
elements of the array are moved into a hash for the purpose of sorting
the file names. Then file names and matching lines are printed.

Q: Can I speed things by eliminating the sed command and letting Perl
filter and modify the matching patterns? If so, how much of a
performance gain?

This is an excerpt from the latest version perlfaq3.pod, which
comes with the standard Perl distribution. These postings aim to
reduce the number of repeated questions as well as allow the community
to review and update the answers. The latest version of the complete
perlfaq is at http://faq.perl.org .

--------------------------------------------------------------------

3.23: Can I write useful Perl programs on the command line?

Yes. Read perlrun for more information. Some examples follow. (These
assume standard Unix shell quoting rules.)

# sum first and last fields
perl -lane 'print $F[0] + $F[-1]' *

# identify text files
perl -le 'for(@ARGV) {print if -f && -T _}' *

# remove (most) comments from C program
perl -0777 -pe 's{/\*.*?\*/}{}gs' foo.c

# make file a month younger than today, defeating reaper daemons
perl -e '$X=24*60*60; utime(time(),time() + 30 * $X,@ARGV)' *

# find first unused uid
perl -le '$i++ while getpwuid($i); print $i'

Cyrus hotmail.com> wrote:

Don't declare %%DiskErr (a hash).

Instead declare $DiskErr (a scalar).

"kunlun" wrote in message
news:1166705621.249976.203980@48g2000cwx.googlegroups.com...
You 're right

I managed
my pb was the $wr where i was systematically forgotting to pass it as a
variable (with $) ...

-----------------------------------------------

You could also code it as:

open(WR, '>', 'rec.txt') or die "Can't open rec.txt for writing: $!";
$ftp->rdir(Filehandle => \*WR);

Cheers,
Rob

There was extra ->, it should be like below I fixed it...thanks a lot:
Coorect: $DiskErr{$sys}->{$el->{'id'}} = { status => $el->{'status'}
};
WRONG: $DiskErr->{$sys}->{$el->{'id'}} = { status => $el->{'status'}
};

Cheers & Have Great Holiday...

Sherm Pendley wrote:

No, he's not declaring it. He's declaring %%DiskErr, when he's using
$DiskErr. Two completely unrelated variables.

Paul Lalli

This is an excerpt from the latest version perlfaq4.pod, which
comes with the standard Perl distribution. These postings aim to
reduce the number of repeated questions as well as allow the community
to review and update the answers. The latest version of the complete
perlfaq is at http://faq.perl.org .

--------------------------------------------------------------------

4.10: Why aren't my random numbers random?

If you're using a version of Perl before 5.004, you must call "srand"
once at the start of your program to seed the random number generator.

BEGIN { srand() if $] < 5.004 }

5.004 and later automatically call "srand" at the beginning. Don't call
"srand" more than once--you make your numbers less random, rather than
more.

"John" yahoo.com> wrote:

:-) The thing is, with insufficient information less people are able to
help you. I often read the documentation of a module I haven't used before
just to see if I can help anyway. You were lucky I have a good memory,
since I used XML::Simple ages ago once or so :-D.

I'm checking the input to functions. The code below is just a snippett
The 'undef' is the problem.
It is being handled as a string.
What would be the simplest method of handling this?

use Data::Dumper;

my %%legal =
(
'extendInto'=> [
{'layer'=>'\S+','comment'=>'\S+','into'=>'\S+','value'=>'\d+','coincidenceOK'=>'[01]'},
];

my %%seed = (
'layer'=>'CONT','comment'=>'xxxx',=>'into'=>undef,'value'=>20,'coincidenceOK'=>1
);

if (isLegal(\@{$legal{extendInto}},\%%seed)){ print "legal\n"; }
else { print "NOT legal\n"; }

Cyrus wrote:

Got what?

Like what?
Please quote some context when replying or nobody will have a clue what you
are talking about.

jue